forked from elastic/elasticsearch
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Register CcrRepository based on settings update (elastic#36086)
This commit adds an empty CcrRepository snapshot/restore repository. When a new cluster is registered in the remote cluster settings, a new CcrRepository is registered for that cluster. This is implemented using a new concept of "internal repositories". RepositoryPlugin now allows implementations to return factories for "internal repositories". The "internal repositories" are different from normal repositories in that they cannot be registered through the external repository api. Additionally, "internal repositories" are local to a node and are not stored in the cluster state. The repository will be unregistered if the remote cluster is removed.
- Loading branch information
1 parent
a5cc353
commit d784ccc
Showing
19 changed files
with
1,012 additions
and
49 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101 changes: 101 additions & 0 deletions
101
server/src/test/java/org/elasticsearch/repositories/RepositoriesModuleTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| /* | ||
| * Licensed to Elasticsearch under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.elasticsearch.repositories; | ||
|
|
||
| import org.elasticsearch.cluster.service.ClusterService; | ||
| import org.elasticsearch.common.settings.Settings; | ||
| import org.elasticsearch.common.xcontent.NamedXContentRegistry; | ||
| import org.elasticsearch.env.Environment; | ||
| import org.elasticsearch.plugins.RepositoryPlugin; | ||
| import org.elasticsearch.test.ESTestCase; | ||
| import org.elasticsearch.threadpool.ThreadPool; | ||
| import org.elasticsearch.transport.TransportService; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.Collections; | ||
| import java.util.List; | ||
|
|
||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| public class RepositoriesModuleTests extends ESTestCase { | ||
|
|
||
| private Environment environment; | ||
| private NamedXContentRegistry contentRegistry; | ||
| private List<RepositoryPlugin> repoPlugins = new ArrayList<>(); | ||
| private RepositoryPlugin plugin1; | ||
| private RepositoryPlugin plugin2; | ||
| private Repository.Factory factory; | ||
|
|
||
| @Override | ||
| public void setUp() throws Exception { | ||
| super.setUp(); | ||
| environment = mock(Environment.class); | ||
| contentRegistry = mock(NamedXContentRegistry.class); | ||
| plugin1 = mock(RepositoryPlugin.class); | ||
| plugin2 = mock(RepositoryPlugin.class); | ||
| factory = mock(Repository.Factory.class); | ||
| repoPlugins.add(plugin1); | ||
| repoPlugins.add(plugin2); | ||
| when(environment.settings()).thenReturn(Settings.EMPTY); | ||
| } | ||
|
|
||
| public void testCanRegisterTwoRepositoriesWithDifferentTypes() { | ||
| when(plugin1.getRepositories(environment, contentRegistry)).thenReturn(Collections.singletonMap("type1", factory)); | ||
| when(plugin2.getRepositories(environment, contentRegistry)).thenReturn(Collections.singletonMap("type2", factory)); | ||
|
|
||
| // Would throw | ||
| new RepositoriesModule(environment, repoPlugins, mock(TransportService.class), mock(ClusterService.class), | ||
| mock(ThreadPool.class), contentRegistry); | ||
| } | ||
|
|
||
| public void testCannotRegisterTwoRepositoriesWithSameTypes() { | ||
| when(plugin1.getRepositories(environment, contentRegistry)).thenReturn(Collections.singletonMap("type1", factory)); | ||
| when(plugin2.getRepositories(environment, contentRegistry)).thenReturn(Collections.singletonMap("type1", factory)); | ||
|
|
||
| IllegalArgumentException ex = expectThrows(IllegalArgumentException.class, | ||
| () -> new RepositoriesModule(environment, repoPlugins, mock(TransportService.class), mock(ClusterService.class), | ||
| mock(ThreadPool.class), contentRegistry)); | ||
|
|
||
| assertEquals("Repository type [type1] is already registered", ex.getMessage()); | ||
| } | ||
|
|
||
| public void testCannotRegisterTwoInternalRepositoriesWithSameTypes() { | ||
| when(plugin1.getInternalRepositories(environment, contentRegistry)).thenReturn(Collections.singletonMap("type1", factory)); | ||
| when(plugin2.getInternalRepositories(environment, contentRegistry)).thenReturn(Collections.singletonMap("type1", factory)); | ||
|
|
||
| IllegalArgumentException ex = expectThrows(IllegalArgumentException.class, | ||
| () -> new RepositoriesModule(environment, repoPlugins, mock(TransportService.class), mock(ClusterService.class), | ||
| mock(ThreadPool.class), contentRegistry)); | ||
|
|
||
| assertEquals("Internal repository type [type1] is already registered", ex.getMessage()); | ||
| } | ||
|
|
||
| public void testCannotRegisterNormalAndInternalRepositoriesWithSameTypes() { | ||
| when(plugin1.getRepositories(environment, contentRegistry)).thenReturn(Collections.singletonMap("type1", factory)); | ||
| when(plugin2.getInternalRepositories(environment, contentRegistry)).thenReturn(Collections.singletonMap("type1", factory)); | ||
|
|
||
| IllegalArgumentException ex = expectThrows(IllegalArgumentException.class, | ||
| () -> new RepositoriesModule(environment, repoPlugins, mock(TransportService.class), mock(ClusterService.class), | ||
| mock(ThreadPool.class), contentRegistry)); | ||
|
|
||
| assertEquals("Internal repository type [type1] is already registered as a non-internal repository", ex.getMessage()); | ||
| } | ||
| } |
Oops, something went wrong.