Build shared libraries by default. #4560
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
force-pushed
the
build-shared-libs
branch
from
5981bf8 to
cdec2ff
Compare
Member
Author
|
CI is green. |
Member
Author
|
Let's merge #4568 first, to verify that the REST CI tests are working again. |
Contributor
|
FYI there is more breakage than the ones you listed as I also had nightlies fail which (currently) need |
ihnorton
approved these changes
Dec 11, 2023
This was referenced Dec 11, 2023
Member
Redo this from a branch in TileDB-Inc please, so we can merge this ASAP. |
Member
Author
|
Opened #4569. |
ihnorton
pushed a commit
that referenced
this pull request
Dec 12, 2023
Restores default behavior to prior to #4528. Supersedes #4560. Fixes TileDB-Inc/TileDB-MariaDB#294 Fixes TileDB-Inc/TileDB-CSharp#339 Fixes TileDB-Inc/TileDB-CSharp#340 Fixes TileDB-Inc/TileDB-CSharp#341 --- TYPE: BUILD DESC: `BUILD_SHARED_LIBS` is enabled by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes behavior regressions.
Fixes TileDB-Inc/TileDB-MariaDB#294
Fixes TileDB-Inc/TileDB-CSharp#339
Fixes TileDB-Inc/TileDB-CSharp#340
Fixes TileDB-Inc/TileDB-CSharp#341
TYPE: BUILD
DESC:
BUILD_SHARED_LIBSis enabled by default.