Stop including the static library when releasing on Windows. #4469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihnorton
approved these changes
Oct 31, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
This PR stops passing `-EnableStaticTileDB` on the Windows release workflow, which means that the release artifacts will include include only the dynamic library, like on other platforms. The size of these artifacts on Windows drops from 175MB [to just 7MB](https://dev.azure.com/TileDB-Inc/CI/_build/results?buildId=35970&view=artifacts&pathAsName=false&type=publishedArtifacts). Users that want to statically link to TileDB will have to build it themselves. TileDB-Java used to do that until TileDB-Inc/TileDB-Java#314, and according to [a search](https://github.com/search?q=TileDB%3A%3Atiledb_static++NOT+is%3Aarchived+NOT+is%3Afork&type=code) of the `TileDB::tiledb_static` string on public non-archived and non-forked repositories, none of these uses would be broken. > [!NOTE] > TileDB-R links statically on Windows as well but it does not use these artifacts so it will not be affected. --- TYPE: BREAKING_BEHAVIOR DESC: The Windows release artifacts no longer include static libraries. (cherry picked from commit af3cbf8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops passing
-EnableStaticTileDBon the Windows release workflow, which means that the release artifacts will include include only the dynamic library, like on other platforms. The size of these artifacts on Windows drops from 175MB to just 7MB.Users that want to statically link to TileDB will have to build it themselves. TileDB-Java used to do that until TileDB-Inc/TileDB-Java#314, and according to a search of the
TileDB::tiledb_staticstring on public non-archived and non-forked repositories, none of these uses would be broken.Note
TileDB-R links statically on Windows as well but it does not use these artifacts so it will not be affected.
TYPE: BREAKING_BEHAVIOR
DESC: The Windows release artifacts no longer include static libraries.