Add support for the CurrentDomain feature #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisStaratzis
force-pushed
the
dstara/sc-51659/wrap-current-domain-in-java-api
branch
3 times, most recently
from
5663c2c to
3d1b478
Compare
DimitrisStaratzis
force-pushed
the
dstara/sc-51659/wrap-current-domain-in-java-api
branch
from
3d1b478 to
23bbe7c
Compare
DimitrisStaratzis
force-pushed
the
dstara/sc-51659/wrap-current-domain-in-java-api
branch
from
f551ae2 to
bb4865f
Compare
DimitrisStaratzis
requested review from
KiterLuc,
Shelnutt2,
ihnorton and
teo-tsirpanis
and removed request for
Shelnutt2
Member
teo-tsirpanis
left a comment
teo-tsirpanis
left a comment
There was a problem hiding this comment.
I didn't thoroughly look at this, but mostly looks good.
| * | ||
| * @param size The size | ||
| */ | ||
| public synchronized void setMinSize(long size) { |
Member
There was a problem hiding this comment.
I'm not sure what the reason for adding synchronized is, but you can remove it from the one-line methods that will call another synchronized method either way.
ihnorton
approved these changes
Sep 3, 2024
DimitrisStaratzis
deleted the
dstara/sc-51659/wrap-current-domain-in-java-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for the Current Domain feature in the Java API