fix maven empty upload #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisStaratzis
force-pushed
the
dstara/maven_fix
branch
2 times, most recently
from
7568577 to
0c9cdc2
Compare
DimitrisStaratzis
force-pushed
the
dstara/maven_fix
branch
from
0c9cdc2 to
c7ecfc9
Compare
ihnorton
approved these changes
Oct 17, 2023
| mv arm/libtiledbjni.dylib ./build/tiledb_jni/arm | ||
|
|
||
| # Linux | ||
| cp libtiledb.so ./build/install/lib |
Member
There was a problem hiding this comment.
Not necessary to make the change in this PR, but at some point soon we should change the structure to use specific subdirectories for each os/architecture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix because our latest maven upload did not contain the native libs. That was caused by #310
The issue is only present in the maven release. Not in the release jar in github.