Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to LuaRocks 3 #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

switch to LuaRocks 3 #27

wants to merge 2 commits into from

Conversation

Tieske
Copy link
Owner

@Tieske Tieske commented Jul 3, 2024

fixes #15

@Tieske Tieske mentioned this pull request Jul 3, 2024
@Tieske
Copy link
Owner Author

Tieske commented Jul 3, 2024

@hishamhm mind having a look?

It uses the same approach; 1 luarocks, in an enviornment with 4 lua versions (5.1 - 5.4). The enviornment is set up based on a specific compiler configuration.

To make it work, I had to copy out "hardcoded.lua", and make it versioned. In the new Luarocks wrapper batch file, the Lua version is set, the matching version of hardcoded.lua is set, and the tree is forced to "system" to keep it self contained.

@hishamhm
Copy link

To make it work, I had to copy out "hardcoded.lua", and make it versioned. In the new Luarocks wrapper batch file, the Lua version is set, the matching version of hardcoded.lua is set, and the tree is forced to "system" to keep it self contained.

If you are making wrapper batch files, it should be possible to set --lua-dir and --lua-version in them, and simply delete hardcoded.lua. If you need to set anything more specific such as LUA_BINDIR, you can set LUAROCKS_CONFIG in the wrapper batch file, and then set any other LuaRocks variables in the config file this variable points to.

The hardcoded.lua file exists only to simplify installations where the installer wants to set some settings in stone. If it is causing you trouble and forcing you to turn it into "soft-coding", then you should just delete it (LuaRocks requires with pcall, so it runs fine without it).

@@ -20,8 +20,8 @@ SET DL_LUAWINMAKE=https://github.com/Tieske/luawinmake/archive/master
SET LUAWINMAKE_TOPFOLDER=luawinmake-master

REM LuaRocks url and top folder name
SET DL_LUAROCKS=https://github.com/keplerproject/luarocks/archive/v%LRVERSION%
SET LUAROCKS_TOPFOLDER=luarocks-%LRVERSION%
SET DL_LUAROCKS=http://luarocks.github.io/luarocks/releases/luarocks-%LRVERSION%-win32.zip
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SET DL_LUAROCKS=http://luarocks.github.io/luarocks/releases/luarocks-%LRVERSION%-win32.zip
SET DL_LUAROCKS=https://luarocks.github.io/luarocks/releases/luarocks-%LRVERSION%-win32.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please update for LuaRocks 3.0.4
2 participants