Skip to content

Fix vector growth check and typos in core #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2025
Merged

Fix vector growth check and typos in core #9

merged 2 commits into from
Jun 25, 2025

Conversation

@TianlongLiang
Copy link
Owner

@TianlongLiang TianlongLiang commented Jun 25, 2025

Summary

  • correct a minor typo in wasm_runtime.c comment
  • fix extend_vector to use max_elems when determining growth
  • clean up typos in bh_vector (log message and comment)

Testing

  • cmake .. (fails: failed to clone simde)

https://chatgpt.com/codex/tasks/task_e_685b97455cb083249e6e2fa9f0651153

@TianlongLiang TianlongLiang changed the base branch from main to collective_fix June 25, 2025 07:08
@TianlongLiang TianlongLiang merged commit 3e95dbc into collective_fix Jun 25, 2025
333 checks passed
TianlongLiang added a commit that referenced this pull request Jun 30, 2025
@TianlongLiang
Collective fix (bytecodealliance#4413)
23799a2 
* Fix vector growth check and typos in core (#9)
* Fix resource cleanup in memory and running modes tests (#10)
* Add end of file empty line in wasm_running_modes_test.cc
@TianlongLiang TianlongLiang deleted the codex/fix-typo-and-bug-in-core branch July 1, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TianlongLiang