Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add url support as optional argument to make_client #80

Merged
merged 3 commits into from
Sep 1, 2019
Merged

add url support as optional argument to make_client #80

merged 3 commits into from
Sep 1, 2019

Conversation

iamsudip
Copy link
Contributor

No description provided.

@iamsudip iamsudip changed the title add url support as option argument to make_client add url support as optional argument to make_client Aug 31, 2019
@codecov
Copy link

codecov bot commented Aug 31, 2019

Codecov Report

Merging #80 into master will increase coverage by 0.17%.
The diff coverage is 74.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   80.61%   80.79%   +0.17%     
==========================================
  Files          35       35              
  Lines        3493     3540      +47     
==========================================
+ Hits         2816     2860      +44     
- Misses        677      680       +3
Impacted Files Coverage Δ
thriftpy2/http.py 78.73% <100%> (+5.27%) ⬆️
thriftpy2/tornado.py 82.6% <63.63%> (-1.4%) ⬇️
thriftpy2/rpc.py 81.69% <64.7%> (-2.53%) ⬇️
thriftpy2/contrib/aio/rpc.py 83.33% <66.66%> (-4.17%) ⬇️
thriftpy2/thrift.py 77.06% <0%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90cbc37...75d8fd0. Read the comment docs.

@ethe
Copy link
Member

ethe commented Sep 1, 2019

I think it is better to change the protocol type in the URL, https:// and tcp:// do not make sense. In my opinion, using thrift:// is better because of the usual practice.

@iamsudip
Copy link
Contributor Author

iamsudip commented Sep 1, 2019

I think it is better to change the protocol type in the URL, https:// and tcp:// do not make sense. In my opinion, using thrift:// is better because of the usual practice.

Agree. Let me change that.

@iamsudip
Copy link
Contributor Author

iamsudip commented Sep 1, 2019

@ethe Have a look now! Made the changes and added more tests to increase coverage ;)

@ethe
Copy link
Member

ethe commented Sep 1, 2019

Merged, thank you.

@ethe ethe merged commit ce676f6 into Thriftpy:master Sep 1, 2019
@iamsudip iamsudip deleted the make_client_with_url_support branch September 1, 2019 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants