Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support kwargs style parameters passing in TSimpleServer #67

Merged
merged 1 commit into from
Jun 16, 2019

Conversation

aisk
Copy link
Member

@aisk aisk commented Jun 16, 2019

kwargs is supported in TThreadedServer, so I think TSimpleServer should support it too.

@codecov
Copy link

codecov bot commented Jun 16, 2019

Codecov Report

Merging #67 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   80.57%   80.57%           
=======================================
  Files          35       35           
  Lines        3480     3480           
=======================================
  Hits         2804     2804           
  Misses        676      676
Impacted Files Coverage Δ
thriftpy2/server.py 37.83% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 726fa8c...507101a. Read the comment docs.

@ethe
Copy link
Member

ethe commented Jun 16, 2019

Yeah it should be, thank you!

@ethe ethe merged commit 61ad54e into Thriftpy:master Jun 16, 2019
@aisk aisk deleted the kwargs branch June 16, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants