-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable include_package_data in setup.py #63
Conversation
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
=======================================
Coverage 80.57% 80.57%
=======================================
Files 35 35
Lines 3480 3480
=======================================
Hits 2804 2804
Misses 676 676 Continue to review full report at Codecov.
|
If you want to package thriftpy2 manually, using |
No, I want using thriftpy2 as a pip dependence, and extend some classes which was written in cython in another package. |
And I think it's a bug that |
Could you please tell me how I can reproduce your issue? |
Running Install my branch using |
That's true, thank you. |
@aisk I will release it later this week, unfortunately there is not a release schedule of thriftpy2 yet. |
Cool, thanks for help! |
The original problem is the
.pyx
and.pxd
files was not packaged in current versions, so it's not possible for extending the cython based classes (cython need source files to compile) in another package besides thriftpy2.I saw there was a
MANIFEST.in
,but theinclude_package_data
is not set insetup.py
, according tosetuptoos 's documents, it should be set to make
MANIFEST
to take efforts. And seems thepackage_data
field is duplicated if we enableinclude_package_data
.