Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #61 parse error on empty set field value #62

Merged
merged 1 commit into from
Jun 1, 2019

Conversation

danieljfarrell
Copy link
Contributor

  • Added a check in the parser to convert lines with empty set constants.
  • To test this followed the example of the email struct and added a metadata struct
    to the email which holdes an empty set of strings. Seemed like the most logical way
    to include parser bug in the existing tests.

 * Added a check in the parser to convert lines with empty set constants.
 * To test this followed the example of the email struct and added a metadata struct
  to the email which holdes an empty set of strings. Seemed like the most logical way
  to include parser bug in the existing tests.
@ethe
Copy link
Member

ethe commented Jun 1, 2019

I merged this, thank you.

@ethe ethe merged commit f4b0030 into Thriftpy:master Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants