Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #41 #42

Merged
merged 3 commits into from
Feb 23, 2019
Merged

Fix #41 #42

merged 3 commits into from
Feb 23, 2019

Conversation

ethe
Copy link
Member

@ethe ethe commented Feb 23, 2019

Fix #41: can not process compound types in struct definition when the IDL is out of order, and other bugs:

  • Unnecessary processing already complete type in out-of-order handler.
  • Can not process out-of-order definitions in submodules with include.

@codecov
Copy link

codecov bot commented Feb 23, 2019

Codecov Report

Merging #42 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   80.46%   80.52%   +0.05%     
==========================================
  Files          35       35              
  Lines        3476     3476              
==========================================
+ Hits         2797     2799       +2     
+ Misses        679      677       -2
Impacted Files Coverage Δ
thriftpy2/parser/__init__.py 84.52% <100%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb60066...1f7e63b. Read the comment docs.

@ethe ethe merged commit 1aa5ef4 into Thriftpy:master Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant