Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i8 as alias for 'byte' #38

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Add i8 as alias for 'byte' #38

merged 1 commit into from
Feb 13, 2019

Conversation

zhaakhi
Copy link
Contributor

@zhaakhi zhaakhi commented Feb 12, 2019

THRIFT-3393 added i8 as an alias for byte, for consistency with the other integer types.

THRIFT-3393 added i8 as an alias for byte, for consistency with the
other integer types.
@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #38 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   80.35%   80.46%   +0.11%     
==========================================
  Files          35       35              
  Lines        3476     3476              
==========================================
+ Hits         2793     2797       +4     
+ Misses        683      679       -4
Impacted Files Coverage Δ
thriftpy2/parser/lexer.py 87.5% <ø> (ø) ⬆️
thriftpy2/parser/parser.py 95.44% <100%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6caab3...18c275f. Read the comment docs.

@ethe
Copy link
Member

ethe commented Feb 13, 2019

LGTM

@ethe ethe merged commit 3aff5db into Thriftpy:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants