Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close socket when connect err #37

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Close socket when connect err #37

merged 1 commit into from
Jan 31, 2019

Conversation

junnplus
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #37 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   80.31%   80.35%   +0.03%     
==========================================
  Files          35       35              
  Lines        3475     3476       +1     
==========================================
+ Hits         2791     2793       +2     
+ Misses        684      683       -1
Impacted Files Coverage Δ
thriftpy2/transport/socket.py 93.12% <100%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e96087...ce522cc. Read the comment docs.

@junnplus junnplus force-pushed the patch-1 branch 2 times, most recently from db668ba to 9ac2d4d Compare January 28, 2019 18:59
@ethe
Copy link
Member

ethe commented Jan 29, 2019

It works for me.

@ethe
Copy link
Member

ethe commented Jan 29, 2019

@wooparadog @microdog

@ethe ethe merged commit a6caab3 into Thriftpy:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants