-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update python_requires
to at lease 3.6 in setpy.py
#243
Conversation
WalkthroughThis update signifies the transition of ThriftPy and ThriftPy2 towards supporting only modern Python versions, by discontinuing support for Python 2.7 and embracing Python 3.6 and newer versions. The modifications include updates to documentation and the setup configuration to align with this strategic shift. Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- README.rst (1 hunks)
- docs/index.rst (1 hunks)
- setup.py (2 hunks)
Files skipped from review due to trivial changes (1)
- docs/index.rst
Additional comments: 2
setup.py (2)
- 85-85: The update to the
python_requires
specifier to'>=3.6'
correctly enforces the requirement thatthriftpy2
needs at least Python 3.6 to run. This change aligns with the PR's objective to drop support for Python 2 and is a crucial step in ensuring that the package is not mistakenly installed on unsupported Python versions.- 95-101: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [85-104]
The Python version classifiers have been updated to reflect the new support policy, listing Python versions 3.6 through 3.12, including both CPython and PyPy implementations. This change accurately communicates the supported Python versions to users and package managers. It's important to ensure that all future Python versions are added to this list as they become officially supported by
thriftpy2
to maintain clarity for the users.
Close #242
Summary by CodeRabbit