Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python_requires to at lease 3.6 in setpy.py #243

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

aisk
Copy link
Member

@aisk aisk commented Feb 28, 2024

Close #242

Summary by CodeRabbit

  • Documentation
    • Updated supported Python versions in documentation to Python 3.6+ and PyPy3.
  • Chores
    • Modified package requirements to necessitate Python version 3.6 or higher.

Copy link

coderabbitai bot commented Feb 28, 2024

Walkthrough

This update signifies the transition of ThriftPy and ThriftPy2 towards supporting only modern Python versions, by discontinuing support for Python 2.7 and embracing Python 3.6 and newer versions. The modifications include updates to documentation and the setup configuration to align with this strategic shift.

Changes

Files Change Summary
README.rst, docs/index.rst Updated supported Python versions to 3.6+ and PyPy3
setup.py Set python_requires to Python 3.6+, updated classifiers

Assessment against linked issues

Objective Addressed Explanation
Remove Python2 support (#242)

Poem

🐇 A Rabbit's Ode to Python 3.6+ 🌟
In the fields of code, where the future lays,
A decision bold, sets the Python 2 sun to haze.
📦 With ThriftPy's leap, to a newer dawn,
Python 3.6+, our allegiance is sworn.
🚀 Let's hop ahead, on this journey so bright,
With modern Python, we code into the night.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@aisk aisk requested a review from ethe February 28, 2024 13:29
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 43463c5 and 6615cf8.
Files selected for processing (3)
  • README.rst (1 hunks)
  • docs/index.rst (1 hunks)
  • setup.py (2 hunks)
Files skipped from review due to trivial changes (1)
  • docs/index.rst
Additional comments: 2
setup.py (2)
  • 85-85: The update to the python_requires specifier to '>=3.6' correctly enforces the requirement that thriftpy2 needs at least Python 3.6 to run. This change aligns with the PR's objective to drop support for Python 2 and is a crucial step in ensuring that the package is not mistakenly installed on unsupported Python versions.
  • 95-101: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [85-104]

The Python version classifiers have been updated to reflect the new support policy, listing Python versions 3.6 through 3.12, including both CPython and PyPy implementations. This change accurately communicates the supported Python versions to users and package managers. It's important to ensure that all future Python versions are added to this list as they become officially supported by thriftpy2 to maintain clarity for the users.

@aisk aisk merged commit d81f47c into Thriftpy:master Feb 28, 2024
8 checks passed
@aisk aisk deleted the sunset-python2 branch February 28, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Python2 support
2 participants