fix: support annotations in union

[pabfuentes]

fix: support annotations in union

Summary by CodeRabbit

• New Features
  • Enhanced support for type annotations in union definitions within the Thrift specification.

[coderabbitai]

Walkthrough

The recent updates involve the introduction of a new foo_union in a Thrift annotations file, which includes boolean and integer fields. Additionally, the thriftpy2 library's parser logic has been enhanced to accommodate type annotations for unions within the Thrift specification, refining the way unions are parsed and interpreted.

Changes

Files	Change Summaries
tests/parser-cases/.../annotations.thrift	Added a foo_union with bool and i32 fields.
thriftpy2/parser/parser.py	Modified union rule to include type_annotations.

🐇✨
In a world of code, changes are afoot,
A union anew, with fields so astute.
Parsing with care, annotations in sight,
A rabbit's delight, in the moonlight.
🌕🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between fc26372 and c257c09.

Files selected for processing (2)

• tests/parser-cases/annotations.thrift (1 hunks)
• thriftpy2/parser/parser.py (1 hunks)

Additional comments: 2

tests/parser-cases/annotations.thrift (1)

• 58-61: Ensure the union foo_union is correctly utilized in tests to verify the parsing of annotations in unions as intended by the PR.

thriftpy2/parser/parser.py (1)

• 232-232: The inclusion of type_annotations in the union production rule aligns with the PR's objective to support annotations in constants, specifically for unions. Ensure this change is covered by unit tests to verify correct parsing behavior.

[aisk]

LGTM, I'll merge this a few days later if other reviewers have no issues with this change. Thanks for your contribution!

[ethe]

LGTM