-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sasl transport support #222
Conversation
Thanks, I am reviewing it. |
I think this change need some test cases to ship with. And since this PR only implment the sasl transport client, maybe we can call some public thrift services with sasl support? |
I agree that tests would be useful. I don't know of any public thrift services with sasl support, so would really like any suggestions here, or alternative methods for testing this code. We have an internal HBase installation that we tested this against, but a full HBase is quite a task to build for a test setup. |
Fully implment the sasl server transport is the best way. Another way is starting a TCP server before running this test case, and the server can be a dummpy server which only send a valid thrift response package while accept and read fixed length of packet. You can dump a thrift packat via wiresharkl or something like it. |
Since this is a new feature and it won't break current users' code, I think we can merge this without testing, if @ecederstrand doesn't have time to finish the work. @ethe any concerns? |
It looks good to me, maybe we could publish a pre-release version that contains this experimental feature. |
Adds pure Python and Cython implementation of sasl transport.