chore: add pyproject.toml and specify build dependencies #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethe
force-pushed
the
build-dependencies
branch
from
a7bfd48 to
1b80073
Compare
ethe
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For latest setuptools, the build step has changed a lot. The main change is the build process is in an isolated environment without any pip packages.
thriftpy2's setup.py is using cython in its import stage, so the setuptools' change caused the CI failed (see: #220, except the python3.6, because it's using old version setuptools).
This commit adds the new style
pyproject.tomland specified cython as the build dependency, so the CI can access cython in build process.Please note that, when publish thriftpy2 to pypi server, we should using the new way described in https://setuptools.pypa.io/en/latest/userguide/quickstart.html, to build files which will be upload to pypi.
Roughly speaking, running
pip install build; python -m buildinstead ofpython setup.py sdist bdist_wheel.