Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support annotations in const #211

Merged
merged 1 commit into from
Mar 30, 2023
Merged

fix: support annotations in const #211

merged 1 commit into from
Mar 30, 2023

Conversation

LYF1999
Copy link
Contributor

@LYF1999 LYF1999 commented Mar 29, 2023

fix: support annotations in const

@LYF1999 LYF1999 marked this pull request as draft March 29, 2023 07:10
@LYF1999 LYF1999 marked this pull request as ready for review March 29, 2023 07:56
@ethe
Copy link
Member

ethe commented Mar 29, 2023

LGTM, cc @aisk

@aisk
Copy link
Member

aisk commented Mar 29, 2023

Can you add some tests for this case?

@ethe
Copy link
Member

ethe commented Mar 29, 2023

Can you add some tests for this case?

I think tests/parser-cases/annotations.thrift is the test case of supporting annotation of constant value. Same as other kinds of annotation, we just need to parse it and skip all passes behind.

@ethe ethe merged commit 77cae32 into Thriftpy:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethe ethe ethe approved these changes

@aisk aisk aisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LYF1999 @ethe @aisk