Fix HTTP_URI typo in http.py #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
=======================================
Coverage 84.05% 84.05%
=======================================
Files 44 44
Lines 4133 4133
=======================================
Hits 3474 3474
Misses 659 659
Continue to review full report at Codecov.
|
ethe
approved these changes
Nov 13, 2020
dmulter
reviewed
Jan 25, 2021
| @@ -60,7 +60,7 @@ | |||
| from thriftpy2.transport import TBufferedTransportFactory | |||
|
|
|||
|
|
|||
| HTTP_URI = '{scheme}://{host}:{port}{path}' | |||
| HTTP_URI = '{scheme}://{host}:{port}/{path}' | |||
|
Really sorry for the break, so should we add a if statement and and the |
|
Your call, but since the standard in |
aisk
added a commit
that referenced
this pull request
Jan 26, 2021
aisk
added a commit
that referenced
this pull request
Jan 26, 2021
aisk
added a commit
that referenced
this pull request
Jan 26, 2021
aisk
added a commit
that referenced
this pull request
Jan 26, 2021
aisk
added a commit
that referenced
this pull request
Jan 26, 2021
aisk
added a commit
that referenced
this pull request
Jan 26, 2021
aisk
added a commit
that referenced
this pull request
Jan 26, 2021
ethe
added a commit
that referenced
this pull request
Jan 27, 2021
Fix the path issue caused by #148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #140