Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception handling in TProcessor #128

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

microdog
Copy link
Contributor

This fixes the issue that exceptions may be dropped silently in TProcessor. The issue was introduced in #4.

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #128 into master will increase coverage by 3.39%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   79.71%   83.11%   +3.39%     
==========================================
  Files          43       43              
  Lines        3905     3908       +3     
==========================================
+ Hits         3113     3248     +135     
+ Misses        792      660     -132
Impacted Files Coverage Δ
thriftpy2/contrib/aio/processor.py 84.31% <100%> (+2.31%) ⬆️
thriftpy2/contrib/tracking/__init__.py 96.45% <100%> (+35.73%) ⬆️
thriftpy2/tornado.py 85.18% <100%> (+2.57%) ⬆️
thriftpy2/contrib/aio/socket.py 78.02% <0%> (+0.54%) ⬆️
thriftpy2/contrib/tracking/tracker.py 86.73% <0%> (+8.16%) ⬆️
thriftpy2/http.py 87.35% <0%> (+8.62%) ⬆️
thriftpy2/thrift.py 88.88% <0%> (+11.82%) ⬆️
thriftpy2/server.py 64.86% <0%> (+27.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b78720e...140854e. Read the comment docs.

@microdog microdog force-pushed the fix-handle-exception branch from 0782756 to c45cb59 Compare March 10, 2020 15:31
@microdog microdog force-pushed the fix-handle-exception branch from c45cb59 to 140854e Compare March 10, 2020 17:26
@microdog microdog marked this pull request as ready for review March 10, 2020 17:31
@ethe
Copy link
Member

ethe commented Mar 11, 2020

LGTM

@ethe ethe merged commit 8ff04dc into Thriftpy:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants