Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing socket_family in make_client #110

Merged
merged 1 commit into from
Dec 28, 2019
Merged

Conversation

aisk
Copy link
Member

@aisk aisk commented Dec 27, 2019

For using thriftpy2 client in IPv6 enviroment.

@codecov
Copy link

codecov bot commented Dec 27, 2019

Codecov Report

Merging #110 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #110      +/-   ##
=========================================
+ Coverage   79.69%   79.7%   +<.01%     
=========================================
  Files          43      43              
  Lines        3901    3902       +1     
=========================================
+ Hits         3109    3110       +1     
  Misses        792     792
Impacted Files Coverage Δ
thriftpy2/rpc.py 81.94% <100%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a5e191...4bae470. Read the comment docs.

Copy link
Member

@ethe ethe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ethe ethe merged commit 08daefd into Thriftpy:master Dec 28, 2019
@aisk
Copy link
Member Author

aisk commented Dec 31, 2019

@ethe Hi, when will we release the next version? I have a project rely on this PR, really thank 🙏!

@ethe
Copy link
Member

ethe commented Dec 31, 2019

I will release the next version this day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants