Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __str__ on TProtocolException #109

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Add __str__ on TProtocolException #109

merged 1 commit into from
Dec 23, 2019

Conversation

aisk
Copy link
Member

@aisk aisk commented Dec 22, 2019

Add __str__ on TProtocolException with same behavior like TApplicationException.

close #104

@codecov
Copy link

codecov bot commented Dec 22, 2019

Codecov Report

Merging #109 into master will decrease coverage by 0.26%.
The diff coverage is 6.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   79.95%   79.69%   -0.27%     
==========================================
  Files          43       43              
  Lines        3887     3901      +14     
==========================================
+ Hits         3108     3109       +1     
- Misses        779      792      +13
Impacted Files Coverage Δ
thriftpy2/protocol/exc.py 40% <6.66%> (-41.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10a0197...36f6f16. Read the comment docs.

@ethe
Copy link
Member

ethe commented Dec 23, 2019

LGTM, thank you!

@ethe ethe merged commit 2a5e191 into Thriftpy:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TProtocolException message is omitted in repr
2 participants