Structs misbehave when hashed

[springheeledjak]

It appears that __hash__ is not overridden for Structs, which is probably not a good thing. They should either (a) be considered non-hashable as dicts are, or (b) have a __hash__ implementation that agrees with __eq__. The former is the more Pythonic, as mutable objects are not valid hash keys.

As an example, the assert below will fail:

#!/usr/bin/env python3
import io
import thriftpy

fp = io.StringIO('''
struct Foo {
    1: i32 id;
}
''')
Foo = thriftpy.load_fp(fp, 'foo.thrift').Foo

assert(set([Foo('bar')]) == set([Foo('bar')]))

Instead, it should probably throw something like TypeError: unhashable type: 'thriftpy.thrift.TPayload'

[springheeledjak]

Thanks! 😄