Upgrade to KubeClient v3 and log failed Kubernetes API requests

src/Ocelot.Provider.Kubernetes/EndPointClientV1.cs

@@ -1,4 +1,4 @@
-using HTTPlease;
+using KubeClient.Http;
 using KubeClient.Models;
 using KubeClient.ResourceClients;
 using Ocelot.Provider.Kubernetes.Interfaces;
@@ -7,11 +7,10 @@ namespace Ocelot.Provider.Kubernetes;
 
 public class EndPointClientV1 : KubeResourceClient, IEndPointClient
 {
-    private readonly HttpRequest _collection;
+    private static readonly HttpRequest Collection = KubeRequest.Create("api/v1/namespaces/{Namespace}/endpoints/{ServiceName}");
 
     public EndPointClientV1(IKubeApiClient client) : base(client)
     {
-        _collection = KubeRequest.Create("api/v1/namespaces/{Namespace}/endpoints/{ServiceName}");
     }
 
     public async Task<EndpointsV1> GetAsync(string serviceName, string kubeNamespace = null, CancellationToken cancellationToken = default)
@@ -21,17 +20,14 @@ public async Task<EndpointsV1> GetAsync(string serviceName, string kubeNamespace
             throw new ArgumentNullException(nameof(serviceName));
         }
 
-        var request = _collection
+        var request = Collection
             .WithTemplateParameters(new
             {
                 Namespace = kubeNamespace ?? KubeClient.DefaultNamespace,
                 ServiceName = serviceName,
             });
 
-        var response = await Http.GetAsync(request, cancellationToken);
-
-        return response.IsSuccessStatusCode
-            ? await response.ReadContentAsAsync<EndpointsV1>()
-            : null;
+        return await Http.GetAsync(request, cancellationToken)
+            .ReadContentAsObjectV1Async<EndpointsV1>(operationDescription: $"get {nameof(EndpointsV1)}");
     }
 }

src/Ocelot.Provider.Kubernetes/Kube.cs

@@ -15,6 +15,8 @@ namespace Ocelot.Provider.Kubernetes;
 /// </remarks>
 public class Kube : IServiceDiscoveryProvider
 {
+    private static readonly (string ResourceKind, string ResourceApiVersion) EndPointsKubeKind = KubeObjectV1.GetKubeKind<EndpointsV1>();
+
     private readonly KubeRegistryConfiguration _configuration;
     private readonly IOcelotLogger _logger;
     private readonly IKubeApiClient _kubeApi;
@@ -46,9 +48,42 @@ public virtual async Task<List<Service>> GetAsync()
             .ToList();
     }
 
-    private Task<EndpointsV1> GetEndpoint() => _kubeApi
-        .ResourceClient<IEndPointClient>(client => new EndPointClientV1(client))
-        .GetAsync(_configuration.KeyOfServiceInK8s, _configuration.KubeNamespace);
+    private async Task<EndpointsV1> GetEndpoint()
+    {
+        string serviceName = _configuration.KeyOfServiceInK8s;
+        string kubeNamespace = _configuration.KubeNamespace;
+
+        try
+        {
+            return await _kubeApi
+                .ResourceClient<IEndPointClient>(client => new EndPointClientV1(client))
+                .GetAsync(serviceName, kubeNamespace);
+        }
+        catch (KubeApiException kubeApiError)
+        {
+            _logger.LogError(() =>
+            {
+                StatusV1 errorResponse = kubeApiError.Status;
+                string httpStatusCode = "Unknown";
+                if (kubeApiError.InnerException is HttpRequestException httpRequestError)
+                {
+                    httpStatusCode = httpRequestError.StatusCode.ToString();
+                }
+
+                return $"Failed to retrieve {EndPointsKubeKind.ResourceApiVersion}/{EndPointsKubeKind.ResourceKind} {serviceName} in namespace {kubeNamespace} ({httpStatusCode}/{errorResponse.Status}/{errorResponse.Reason}): {errorResponse.Message}";
+            }, kubeApiError);
+        }
+        catch (HttpRequestException unexpectedRequestError)
+        {
+            _logger.LogError(() => $"Failed to retrieve {EndPointsKubeKind.ResourceApiVersion}/{EndPointsKubeKind.ResourceKind} {serviceName} in namespace {kubeNamespace} ({unexpectedRequestError.HttpRequestError}/{unexpectedRequestError.StatusCode}).", unexpectedRequestError);
+        }
+        catch (Exception unexpectedError)
+        {
+            _logger.LogError(() => $"Failed to retrieve {EndPointsKubeKind.ResourceApiVersion}/{EndPointsKubeKind.ResourceKind} {serviceName} in namespace {kubeNamespace} (an unexpected error occurred).", unexpectedError);
+        }
+
+        return null;
+    }
 
     private bool CheckErroneousState(EndpointsV1 endpoint)
         => (endpoint?.Subsets?.Count ?? 0) == 0; // null or count is zero

src/Ocelot.Provider.Kubernetes/Ocelot.Provider.Kubernetes.csproj

@@ -25,8 +25,8 @@
     <NoWarn>1591</NoWarn>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="KubeClient" Version="2.5.12" />
-    <PackageReference Include="KubeClient.Extensions.DependencyInjection" Version="2.5.12" />
+    <PackageReference Include="KubeClient" Version="3.0.0" />
+    <PackageReference Include="KubeClient.Extensions.DependencyInjection" Version="3.0.0" />
     <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.556">
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>