Use errors.Is for error comparison instead of direct equality checks #502
Conversation
|
|
||
| "github.com/ThreeDotsLabs/watermill/message" | ||
|
|
||
| "github.com/ThreeDotsLabs/watermill/message/router/middleware" | ||
| "github.com/pkg/errors" |
There was a problem hiding this comment.
I dont see a need for this deprecated one
Remove it, so you can use errors directly without an alias
The call to errors.Wrap can be replaced by fmt.Errorf("%w ...")
errors.New can be used directly from stdlib
There was a problem hiding this comment.
It looks like errors.Cause is being used in the current implementation, which makes it a bit more challenging to simply remove the alias.
There was a problem hiding this comment.
From what I had seen before raising my point, errors.Cause is used only in the code, not in the test file I quoted.
But, I have missed something. And I was wrong
There is this indeed.
assert.Equal(t, errFailed, errors.Cause(multierr.WrappedErrors()[1]))this could be rewritten to use maybe
assert.ErrorIs(t, multierr, errFailed)
|
Also, maybe it's time to enable some golangci-lint linters https://golangci-lint.run/usage/linters/ err113 is exacly the linter you need for catching what you are fixing. errorlint is a good addition Of course, this could be considered separately from this PR |
This PR refactors error handling by replacing direct comparisons of errors (e.g., err == someError) with the use of errors.Is.