Initialize subscribers for each consumer group #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks for your contribution, @breml! |
cchatfield
added a commit
to sidkik/watermill
that referenced
this pull request
Nov 10, 2021
* Initialize subscribers for each consumer group (ThreeDotsLabs#225) Co-authored-by: Lucas Bremgartner <[email protected]> * Proper Message nil m.ack handling (ThreeDotsLabs#227) when Message.Ack invoke in bad situation, maybe better. * Added exactly-once delivery example (ThreeDotsLabs#228) * Added exactly-once delivery example * added README for example * readme cosmetics * readme cosmetics * readme cosmetics * Update README.md * update deps * README cosmetics Co-authored-by: Miłosz Smółka <[email protected]> * Added new example to README.md * Fix netlify build (ThreeDotsLabs#236) * fix netlify build * fix hugo version * fix build * Added Discord server link * Add watermill-firestore to the list of Pub/Subs (ThreeDotsLabs#234) * Add watermill-firestore to the list of Pub/Subs * Add last_line_equals and cleanup the docs * Consumer groups are not supported * Add some context to why this pub/sub is useful * Return the handler instance created within AddNoPublisherHandler (ThreeDotsLabs#229) * Add `mill googlecloud subscription ls` (ThreeDotsLabs#220) * Add `mill googlecloud subscription ls` * fix * sort imports * Remove unnecessary change * Update README * update deps * Update deps and Go (ThreeDotsLabs#245) * Fix master build due deps error * update deps * update Go in build image * update all Go versions * Stress tests bugfix * Added dynamic stress test config * Mark consumer groups as supported (ThreeDotsLabs#246) Consumer groups are currently marked as supported here https://github.com/ThreeDotsLabs/watermill-firestore/blob/master/pkg/firestore/pubsub_test.go#L53 Co-authored-by: Lucas Bremgartner <[email protected]> Co-authored-by: Lucas Bremgartner <[email protected]> Co-authored-by: Ding <[email protected]> Co-authored-by: Robert Laszczak <[email protected]> Co-authored-by: Miłosz Smółka <[email protected]> Co-authored-by: Filip Borkiewicz <[email protected]> Co-authored-by: Trevor Foster <[email protected]> Co-authored-by: Maciej Bratek <[email protected]> Co-authored-by: Robert Laszczak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on an implementation for #126 (PostgreSQL driver with
SKIP LOCKED), I found it necessary to initialize for each subscriber group. Therefore I needed to add theSubscribeInitializeingenerateConsumerGroup, which is used by the testTestConsumerGroups.