Update default OTLP http port (open-telemetry#939)

ThomsonTan · Aug 4, 2021 · 05444a8 · 05444a8
1 parent dc25ea6
commit 05444a8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/exporters/otlp/README.md b/exporters/otlp/README.md
@@ -44,9 +44,10 @@ auto exporter = std::unique_ptr<sdktrace::SpanExporter>(new otlp::OtlpHttpExport
 
 ### Configuration options
 
-| Option       | Default          |
-| ------------ |----------------- |
-| `endpoint`   | `localhost:4317` |
+| Option                               | Default          |
+| ------------------------------------ |----------------- |
+| `OtlpGrpcExporterOptions.endpoint`   | `localhost:4317` |
+| `OtlpHttpExporterOptions.endpoint`   | `localhost:4318` |
 
 ## Example
 

diff --git a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_exporter.h b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_exporter.h
@@ -50,7 +50,7 @@ struct OtlpHttpExporterOptions
   // @see
   // https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/otlp.md
   // @see https://github.com/open-telemetry/opentelemetry-collector/tree/main/receiver/otlpreceiver
-  std::string url = std::string("http://localhost:4317") + kDefaultTracePath;
+  std::string url = std::string("http://localhost:4318") + kDefaultTracePath;
 
   // By default, post json data
   HttpRequestContentType content_type = HttpRequestContentType::kJson;