update #11
Merged
update #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes from central respository
180717_addingChangesFromCn1Repository
…a potential issue with hint text localization in the search bar
…ldDrawImage returns true - while the placeholder is being drawn. This fixes an NPE on Android when using a URLImage with a FontImage placeholder as a component background image - e.g. using ScaleLabel
…rs off the EDT - or if AWT paints are initiated off of the AWT dispatch thread.
…ion when using BrowserComponent.executeAndReturnString()
…droid. Added some more precautions in Android Browser component to guard against possible deadlocks. Hoping that it fixes this issue: #2177 Although I have been unable to reproduce the issue on my test devices.
…laying so that it will pick up the correct width and height of the video. Without this, in some cases, the video would appear to be blank until a revlidation of the form occurred.
…rs to figure out the right resolution.
…on case will now update on UIID change
… servers already
… before the browser component has finished loading its callback plumbing. This fixes an issue with the browser component showing a 404 error on the codenameone site. E.g. https://stackoverflow.com/questions/45664270/strange-behavior-of-code-name-one-browser-component-in-the-simulator
merging changes from codenameone respository
…nly in the top inset, and it indicates that the component will be laid out such that its text baseline is aligned with the reference component's text baseline.
… a null check to all field accesses. The default if false right now - to not include the null checks. This will be connected to the ios.fieldNullChecks build hint.
…rectly when lightweight peer is repositioned. This, in particular, fixes some issues with placing browser components inside Tabs. #2162
…order use millimeter thickness
…ch. This resolves the initial complaint of issue #2156 . However, keeping that issue open because we still need to verify that ios and android work consistently and that it is documented.
…e after transition animation.
Fixed NullPointerException and make day buttons to occupy their actual size rather than the Grid size, using FlowLayout.
…ir actual size rather than the Grid size, using FlowLayout."
Revert "Fixed NullPointerException and make day buttons to occupy their actual size rather than the Grid size, using FlowLayout."
…tring formats. Changed inlineStyleTheme to cascade so that a component will look at its parents inlineStyleTheme if its own is null. This enables us to just add the theme to the parent form, and all components in the form can reference the same theme. Encapsulated all aspects of style strings in the StyleInfo class which is capable of parsing strings, manipulating all aspects of the styles, and writing the styles back to a string. This functionality enables rich editing components for styles in the GUI builder. Primary difference between XXXInfo (StyleInfo, BorderInfo, FontInfo, ImageInfo) classes and their counterparts (Style, Border, Font, Image) is that the XXXInfo classes simply contain information on how to create their counterpart. For example, a BorderInfo object that describes an image border doesn't actually include the Image - rather it just includes the image names or paths so that they can be edited at more easily offline, and the actual Border gets created at runtime. Again, these changes correspond with some new features in the GUI builder which will be committed soon.
…e events are pouring in and an invoke and block was triggered on one of those events.
Fixed a bug with full screen layered layout that failed to draw the background form in some cases
…aint based layout
Fixed onTopSideMenu drag behavior bugs such as click after drag of the side menu Made the tinting softer to match native behavior
…cases that add complexity to this (e.g. UIID may be resolved before component has a parent, and would need to be re-resolved when parent changes), and it creates a worst-case potential performance hit even when inline styles aren't used (e.g. if component is very deep in hierarchy).
"Always on Top" checkbox is not checked because alwaysOnTop is false by the time `installMenu(window, true);` is called.
Initialize alwaysOnTop before installing the menu
Developers will have to override many methods for this to work.
Below is an example of this customization and the overriding methods:
``
private Calendar monthCal = new Calendar() {
//<editor-fold defaultstate="collapsed" desc="Calendar overriding">
@OverRide
protected Component createDayComponent() {
Button btnDay = new Button("");
Container cont = FlowLayout.encloseCenterMiddle(btnDay);
cont.setLeadComponent(btnDay);
return cont;
}
@OverRide
protected void bindDayListener(Component cmp, ActionListener l) {
((Button) ((Container) cmp).getLeadComponent()).addActionListener(l);
}
@OverRide
protected void setDayText(Component cmp, String text) {
((Button) ((Container) cmp).getLeadComponent()).setText(text);
}
@OverRide
protected String getDayText(Component cmp) {
return ((Button) ((Container) cmp).getLeadComponent()).getText();
}
@OverRide
protected void setDayUIID(Component cmp, String uiid) {
((Container) cmp).getLeadComponent().setUIID(uiid);
}
@OverRide
protected void setDayEnabled(Component cmp, boolean uiid) {
((Container) cmp).getLeadComponent().setEnabled(uiid);
}
@OverRide
protected void updateButtonDayDate(Component cmp, int currentMonth, int
day) {
super.updateButtonDayDate((Button) ((Container) cmp).getLeadComponent(),
currentMonth, day);
}
@OverRide
protected void updateButtonDayDate(Component dayButton, int year, int
currentMonth, int day) {
super.updateButtonDayDate((Button) ((Container)
dayButton).getLeadComponent(), currentMonth, day);
}
//</editor-fold>
};
``
Allow creating an abbitrary day component for better customization
…tton The method below currently toggles open and close, it should do the same for `onTopSideMenu`. menuButton.addActionListener(evt -> getToolbar().openSideMenu());
JavaDoc Improvement - changed "an" to "a" where applicable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.