fix conditions for PR tests #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anirudh2290
reviewed
Sep 12, 2019
| @@ -1418,7 +1420,9 @@ def docs_python() { | |||
| timeout(time: max_time, unit: 'MINUTES') { | |||
| utils.unpack_and_init('libmxnet', mx_lib, false) | |||
| utils.docker_run('ubuntu_cpu_python', 'build_python_docs', false) | |||
| utils.pack_lib('python-artifacts', 'docs/_build/python-artifacts.tgz', false) | |||
| if (env.BRANCH_NAME == "master" || env.BRANCH_NAME.startsWith("new_")) { | |||
There was a problem hiding this comment.
branch_name starting with new_, are you sure this wont trigger other branches not related to website ?
There was a problem hiding this comment.
Nope, but all it'll do is slow down the validation on a PR named "new_*" because of the stash... and that PR would have to have this latest code...
We can remove it after the PR is done testing (before or just after merge)... but I had to have a way to be able to trigger it outside of master.
There was a problem hiding this comment.
Stashing add several minutes per docs package... so... it's just optimization...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR streamlines the PR validation process. It will skip stashing of the artifacts when the branch is not master or "new_*".
I also removed the remnants of the S3 publishing since there's not a good solution for it yet anyway.
The later is so we can test it.