Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: testingicon (original, plain) #44

Closed
wants to merge 8 commits into from
Closed

Conversation

Thomas-Boi
Copy link
Owner

Test PR, do not merge

@Thomas-Boi Thomas-Boi added the bot:peek Use this label so GitHub Actions bot can peek at the new icons that label Aug 7, 2021
@github-actions
Copy link

github-actions bot commented Aug 7, 2021

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

0

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@Thomas-Boi Thomas-Boi added bot:peek Use this label so GitHub Actions bot can peek at the new icons that and removed bot:peek Use this label so GitHub Actions bot can peek at the new icons that labels Aug 7, 2021
@github-actions

This comment has been minimized.

@Thomas-Boi Thomas-Boi added bot:peek Use this label so GitHub Actions bot can peek at the new icons that and removed bot:peek Use this label so GitHub Actions bot can peek at the new icons that labels Aug 9, 2021
@github-actions

This comment has been minimized.

@Thomas-Boi Thomas-Boi added bot:peek Use this label so GitHub Actions bot can peek at the new icons that and removed bot:peek Use this label so GitHub Actions bot can peek at the new icons that labels Aug 9, 2021
@github-actions
Copy link

github-actions bot commented Aug 9, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs. This is how Icomoon intepret the uploaded SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons. This is what the font will look like:
Imgur Images

You can click on the pictures and zoom on them if needed.

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs.
Check this doc for more details and fix the issues as
instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repo.

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label so GitHub Actions bot can peek at the new icons that
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant