Skip to content

Add settings menu to controls panel #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreadelrio wants to merge 6 commits into
base: controls/controlFrame
Choose a base branch
from
Open

Add settings menu to controls panel #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ef88ac2
clean up flyout
andreadelrio Aug 24, 2021
dddbf30
more work on edit forms
andreadelrio Aug 26, 2021
b2e33bf
progress
andreadelrio Aug 31, 2021
1fd575b
added more options to context menu
andreadelrio Aug 31, 2021
2e051e3
adding the pencil icon
andreadelrio Sep 1, 2021
5167707
adjust pencil icon positions
andreadelrio Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions ...eddable_examples/public/searchable_list_container/searchable_list_container_component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,16 +141,13 @@ export class SearchableListContainerComponentInner extends Component<Props, Stat
</EuiButton>
</EuiFormRow>
</EuiFlexItem>
<EuiFlexItem>
<EuiFormRow label="Filter">
<EuiFieldText
data-test-subj="filterTodos"
value={this.props.input.search || ''}
onChange={(ev) => this.updateSearch(ev.target.value)}
/>
</EuiFormRow>
</EuiFlexItem>
<EuiFlexItem />
<EuiFormRow label="Filter">
<EuiFieldText
data-test-subj="filterTodos"
value={this.props.input.search || ''}
onChange={(ev) => this.updateSearch(ev.target.value)}
/>
</EuiFormRow>
</EuiFlexGroup>
);
}
Expand Down
16 changes: 13 additions & 3 deletions ...ation_util/public/components/input_controls/control_group/control_frame/control_frame.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import React, { useMemo } from 'react';
import useMount from 'react-use/lib/useMount';
import classNames from 'classnames';
import { EuiFormControlLayout, EuiFormLabel, EuiFormRow } from '@elastic/eui';
import { EuiFormControlLayout, EuiFormLabel, EuiFormRow, EuiIcon } from '@elastic/eui';

import { InputControlEmbeddable } from '../../embeddable/types';

Expand All @@ -31,7 +31,10 @@ export const ControlFrame = ({ twoLine, embeddable }: ControlFrameProps) => {
fullWidth
prepend={
twoLine ? undefined : (
<EuiFormLabel htmlFor={embeddable.id}>{embeddable.getInput().title}</EuiFormLabel>
<EuiFormLabel className="controlFrame__prepend" htmlFor={embeddable.id}>
<EuiIcon className="controlFrame__prependIcon" type="pencil" />
{embeddable.getInput().title}
</EuiFormLabel>
)
}
>
Expand All @@ -46,8 +49,15 @@ export const ControlFrame = ({ twoLine, embeddable }: ControlFrameProps) => {
</EuiFormControlLayout>
);

const twoLineLabel = (
<>
{embeddable.getInput().title}
<EuiIcon className="controlFrame__labelIcon" size="m" type="pencil" />
</>
);

return (
<EuiFormRow fullWidth label={twoLine ? embeddable.getInput().title : undefined}>
<EuiFormRow fullWidth label={twoLine ? twoLineLabel : undefined}>
{form}
</EuiFormRow>
);
Expand Down
25 changes: 20 additions & 5 deletions ...ugins/presentation_util/public/components/input_controls/control_group/control_group.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,17 @@
.controlFrame--formControlLayout {
width: 100%;
min-width: $euiSize * 14;
.controlFrame__prepend {
padding-left: $euiSizeXS;
}
.controlFrame__prependIcon {
margin-top: - $euiSizeXS;
}
}

.controlFrame__labelIcon {
margin-left: $euiSizeXS;
margin-top: - $euiSizeXS;
}

.controlFrame--control {
Expand All @@ -39,9 +50,13 @@
min-width: $euiSize * 12;
}

.controlGroup--sortItem {
&-isDragging {
@include euiBottomShadow;
background: $euiColorEmptyShade;
}
// .controlGroup--sortItem {
// &-isDragging {
// @include euiBottomShadow;
// background: $euiColorEmptyShade;
// }
// }

.controlGroup--sortItemDraggable {
padding: $euiSizeXS 0;
}
2 changes: 1 addition & 1 deletion ...sentation_util/public/components/input_controls/control_group/control_group_component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export const ControlGroupComponent = ({
setControlMeta={setControlMeta}
setControlStyle={setControlStyle}
/>
<EuiSpacer size="l" />
<EuiSpacer size="s" />
<EuiFlexGroup alignItems="center" wrap={true} gutterSize={'s'}>
{controlMeta.map(({ embeddableId, width }) => (
<EuiFlexItem
Expand Down
Loading