whisperX to create transcripts #28
Conversation
audio_builder.py
Outdated
| @@ -26,6 +27,12 @@ | |||
| cloudConfig = configparser.ConfigParser() | |||
| cloudConfig.read('cloud_service_settings.ini') | |||
|
|
|||
| # Get the video file name and create the output folder based on the original video file name | |||
| originalVideoFile = os.path.abspath(batchConfig['SETTINGS']['original_video_file_path'].strip("\"")) | |||
There was a problem hiding this comment.
I see some calls to the settings file with original_video_file_path, however, the config file remains unchanged, I think that creating a commit with these new settings and a default value would avoid some unexpected behavior on users that do not look into the code
There was a problem hiding this comment.
I think it's best to remove this for now
main.py
Outdated
| @@ -72,6 +72,11 @@ | |||
| originalVideoFile = os.path.abspath(batchConfig['SETTINGS']['original_video_file_path'].strip("\"")) | |||
| srtFile = os.path.abspath(batchConfig['SETTINGS']['srt_file_path'].strip("\"")) | |||
|
|
|||
| # Create the output folder based on the original video file name | |||
| fileName = os.path.basename(originalVideoFile).split(".")[0] | |||
There was a problem hiding this comment.
Isn't this the same as the code in audio_builder.py?
Also, there's already some code to handle the creation of output folders in Line 479 of the main file, in my opinion, moving this implementation there (or replacing the existing one) would be a better fit for this code.
|
Instead of adding this to requirements.txt, I'll probably want to implement it optionally somehow. Maybe add a message to be displayed when the script is run saying how to install it. |
PLEASE ONLY SUBMIT PULL REQUESTS FOR BUG FIXES OR LEGITIMATELY USEFUL ADDITIONAL FUNCTIONALITY
I know many of you are enthusiastic to help but I don't want this project to become bloated
Type of change
Proposed Changes
Additional Info
Checklist:
Required: