Repository navigation
Feature/t228 welcome modal onboarding - #67
Merged
Merged
Conversation
…and safe pendingTasks fallback
…shboard approval totals
…g by route permissions
…g by route permissions
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughPR thêm trang hồ sơ, dịch vụ hồ sơ và điều hướng mới. PR thêm modal chào mừng có trạng thái lưu trữ. PR mở rộng dashboard với dữ liệu tổng quan, biểu đồ và kiểm tra quyền. PR sửa hiển thị loại phiếu trong màn hình phê duyệt. ChangesHồ sơ và chào mừng
Dashboard theo quyền
Hiển thị phê duyệt
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/App.vue`:
- Around line 2-30: Update App.vue to watch isAuthLayout and run
shouldShowWelcomeModal() when the value transitions from true to false, so users
redirected from the auth layout receive onboarding. Preserve the existing
localStorage check and closeWelcomeModal behavior, and avoid opening the modal
while the route remains in the auth layout.
In `@src/components/WelcomeModal.vue`:
- Around line 40-45: Cập nhật WelcomeModal để quản lý focus khi mở và đóng: lưu
phần tử đang focus, chuyển focus vào dialog hoặc nút đầu tiên, giới hạn điều
hướng Tab trong modal để không chạm tới AppSidebar/AppTopbar phía sau, rồi khôi
phục focus đã lưu khi đóng. Gắn logic vào các hook hoặc hàm mở/đóng hiện có của
WelcomeModal, giữ nguyên hành vi modal ngoài việc bổ sung quản lý focus.
In `@src/views/DashboardView.vue`:
- Line 767: Update the chart render condition in the DashboardView template to
use the top-level dashboardOverview value directly, replacing
dashboardOverview.value with dashboardOverview. Preserve the existing v-else-if
rendering behavior for valid API responses.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: c5459e1f-b010-46be-b86c-ca51be29d2a6
📒 Files selected for processing (11)
src/App.vuesrc/components/AppSidebar.vuesrc/components/WelcomeModal.vuesrc/router/index.jssrc/services/dashboardService.jssrc/services/productService.jssrc/services/profileService.jssrc/services/warehouseService.jssrc/views/ApprovalsView.vuesrc/views/DashboardView.vuesrc/views/ProfileView.vue
…dashboard template ref fix
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/WelcomeModal.vue`:
- Around line 65-71: Thêm thuộc tính tabindex="-1" vào phần tử div dialog được
tham chiếu bởi dialogRef trong WelcomeModal.vue để lời gọi
dialogRef.value.focus() trong enforceFocus có thể đặt lại focus vào modal khi
focus thoát ra ngoài. Giữ nguyên logic xử lý focus hiện tại.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: e05aef5b-9491-4aa4-85d2-0071a8384665
📒 Files selected for processing (3)
src/App.vuesrc/components/WelcomeModal.vuesrc/views/DashboardView.vue
ThienlocTran
reviewed
Aug 4, 2026
| </Teleport> | ||
| </template> | ||
|
|
||
| <style scoped> |
Owner
There was a problem hiding this comment.
Nên tách css ra file riêng rồi gọi qua thui cho nó nhẹ class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check giúp tui
Summary by CodeRabbit
Tính năng mới
Cải tiến