Remove global token and init()

[amelchio]

This removes the global token and instead uses a per-Client value, allowing access to multiple registered applications by initializing several Client objects.

The issue was reported in home-assistant/core#11641

[jwater7]

@Thibauth - can you take a look at this pr and see if a new release can be made with it included? There’s a few of us waiting on a fix to get pushover working again in Home Assistant - thanks!

[Thibauth]

Thanks a lot for the fix @amelchio ! The use of a global api_token was indeed ugly (not to mention bug-inducing in contexts where one want to use multiple tokens) and something I wanted to fix eventually. Your PR looks good to me and I would be happy to merge it and create a new release.

However, I now wonder whether a better way to structure this library would be to have a Pushover class instantiated with the API token. This class would have a send method taking as argument the user key. So the flow would look like this:

po = Pushover(api_token)
po.send(user_key, "Hello world!")

I would be curious to hear your opinion about this. If we believe this is better, then I would prefer to make this change before a new release so as to minimize the number of backward incompatible changes.

[amelchio]

I see where you are coming from. For the Home Assistant case, though, we have just a single user_key and having it in the constructor is fine.

I don't have much of an opinion either way. I only passed by trying to fix this bug :)

[jwater7]

Any movement on this? - to me, it looks good to merge so that the bugs are fixed, then we can focus on ways to improve?

[amelchio]

At this point, I agree with @jwater7 :)

[amelchio]

@Thibauth what's the status on this one? :-)

[Thibauth]

Sorry for the long period of inactivity, I just started working back on this. I ended up going for the bigger refactoring that I described above. This breaks backward compatibility but I think it is better in the long run. If you have a chance, it would be great if you could test to make sure everything is alright. I also need to update the documentation to reflect the changes and make a new release.

[amelchio]

I adjusted to your changes and it works fine 👍. So please go ahead and make a new release :-)

[amelchio]

Do you have an ETA for this?

[asyba]

any news about this??

[ashmckenzie]

@Thibauth is there any news on your refactor? Are we able to assist at all?

[amelchio]

@Thibauth If you have not planned more changes, could you please do a PyPI release?

[amelchio]

It has been a year now. At this point I consider the project abandoned so I am going to close this PR.

[jwater7]

NOTICE: Now that Apprise is available (https://www.home-assistant.io/integrations/apprise/) (https://github.com/caronc/apprise/) I've migrated my automatons to use the new apprise notify service (using the pushover/pover URL) and I no longer have this issue.