Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.1.1 after fixing package setup #18

Merged
merged 5 commits into from
Sep 13, 2023
Merged

Release v0.1.1 after fixing package setup #18

merged 5 commits into from
Sep 13, 2023

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Sep 12, 2023

📑 PR details:
This PR includes the version 0.1.1 of nbaflow package after fixing the project setup and package structure.


🔗 Chained issues
This PR eventually will close the following issues:
No issues in this PR


🔨 Tasks done:

  • Applied fixes on setup.py file
  • Included __init__.py files

✔️ Checklist:

  • New code followed the best practices
  • New features were tested properly
  • There is no chance new features would compromise the project

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -17.59% ⚠️

Comparison is base (ae1ec0b) 77.58% compared to head (86fd0f0) 60.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #18       +/-   ##
===========================================
- Coverage   77.58%   60.00%   -17.59%     
===========================================
  Files           5        6        +1     
  Lines          58       75       +17     
===========================================
  Hits           45       45               
- Misses         13       30       +17     
Files Changed Coverage Δ
nbaflow/players.py 50.00% <0.00%> (ø)
nbaflow/utils/log.py 100.00% <ø> (ø)
nbaflow/utils/requests.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThiagoPanini ThiagoPanini changed the title pr(main): refs/heads/v0.1.1 -> main Release v0.1.1 after fixing package setup Sep 13, 2023
@ThiagoPanini ThiagoPanini self-assigned this Sep 13, 2023
@ThiagoPanini ThiagoPanini added enhancement 🍀 General improvements on application code bug 🐞 When code doesn't work as expected due to bugs and removed enhancement 🍀 General improvements on application code labels Sep 13, 2023
@ThiagoPanini ThiagoPanini merged commit 72da2d8 into main Sep 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 When code doesn't work as expected due to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant