refactor: type cast error instead of conditional check

Theodo-UK · Jul 21, 2023 · d998849 · d998849
1 parent 2d42293
commit d998849
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 20 deletions.
diff --git a/src/background/background.ts b/src/background/background.ts
@@ -31,17 +31,15 @@ chrome.runtime.onMessage.addListener(async (message, sender, sendResponse) => {
         try {
             await chrome.debugger.detach({ tabId: tabId });
         } catch (e: unknown) {
-            if (e instanceof Error) {
-                if (
-                    e.message ===
-                    `Debugger is not attached to the tab with id: ${tabId}.`
-                ) {
-                    console.warn(
-                        `Tried to detach debugger from tab (tabId: ${tabId}) when there was none attached. `
-                    );
-                    return;
-                }
-                throw e;
+            const error = e as Error;
+            if (
+                error.message ===
+                `Debugger is not attached to the tab with id: ${tabId}.`
+            ) {
+                console.warn(
+                    `Tried to detach debugger from tab (tabId: ${tabId}) when there was none attached. `
+                );
+                return;
             }
             throw e;
         }

diff --git a/src/background/backgroundHelpers.ts b/src/background/backgroundHelpers.ts
@@ -11,15 +11,15 @@ export const addBytesTransferred = async (bytes: number) => {
             },
         });
     } catch (e: unknown) {
-        if (e instanceof Error) {
-            if (
-                e.message ===
-                "Could not establish connection. Receiving end does not exist."
-            ) {
-                console.warn(
-                    `Error Caught: ${e}\nIf popup is open and this error is seen in the console, debugging is required.`
-                );
-            }
+        const error = e as Error;
+
+        if (
+            error.message ===
+            "Could not establish connection. Receiving end does not exist."
+        ) {
+            console.warn(
+                `Error Caught: ${e}\nIf popup is open and this error is seen in the console, debugging is required.`
+            );
         } else {
             throw e;
         }