This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Add response_format to allow use of new JSON mode
#449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzhu-ai
reviewed
Jan 17, 2024
| * When specifying 'json_object' as the request format it's still necessary to instruct the model to return JSON. | ||
| * You may use {@link ChatResponseFormat.ResponseFormat} enum. | ||
| */ | ||
| @JsonProperty("response_format") |
There was a problem hiding this comment.
I think you can just put the class ChatResponseFormat within the request class
There was a problem hiding this comment.
I tried to follow the format that was used for other attributes.
erdemt
approved these changes
Jan 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I added an attribute to the ChatCompletionRequest class to support JSON mode. Resolves issue #448 .
New API Checklist
See CONTRIBUTING.md for more info.