Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Properly handle card clicks in storybook #549

Closed
Thenlie opened this issue Sep 24, 2023 · 3 comments · Fixed by #628
Closed

🐞 Properly handle card clicks in storybook #549

Thenlie opened this issue Sep 24, 2023 · 3 comments · Fixed by #628
Assignees
@Thenlie
Labels
type: bug Something isn't working type: storybook Creating or updating a storybook file
Milestone
1.10.0

Comments

@Thenlie
Copy link
Owner

Thenlie commented Sep 24, 2023

This ticket should tackle two issues.

  1. When clicking on a show card in storybook, nothing should happen. We will need to override the default onClick behavior to do this.
  2. Add a generic error boundary component to gracefully handle any future errors. This should be applied to all existing stories.

Image
@Thenlie Thenlie changed the title Properly handle card clicks in storybook 🐞 Properly handle card clicks in storybook Sep 24, 2023
@Thenlie Thenlie added type: bug Something isn't working type: storybook Creating or updating a storybook file labels Sep 24, 2023
@Thenlie Thenlie self-assigned this Sep 26, 2023
@Thenlie Thenlie modified the milestones: 1.8.0, 1.9.0 Sep 26, 2023
@Thenlie
Copy link
Owner Author

Thenlie commented Sep 28, 2023

This might actually not be possible.

https://discord.com/channels/486522875931656193/1156113545071697920/1156113545071697920

JesusTheHun/storybook-addon-remix-react-router#51

@Thenlie
Copy link
Owner Author

Thenlie commented Sep 30, 2023

So this is not possible. We have a few options:

  1. Pass in the onClick behavior as props
  2. Just add an errorElement and leave it

I think I will go with the second option and just mention this issue in our docs.

@Thenlie Thenlie modified the milestones: 1.9.0, 1.10.0 Oct 11, 2023
Thenlie added a commit that referenced this issue Oct 21, 2023
@Thenlie
#549 fix storybook click error
f4368b1
Thenlie added a commit that referenced this issue Oct 21, 2023
@Thenlie
#549 remove unused storybook dependencies
53d8ac0
@Thenlie Thenlie mentioned this issue Oct 21, 2023
Merged
@Thenlie Thenlie linked a pull request Oct 21, 2023 that will close this issue
fix storybook clicks #628
Merged
Thenlie added a commit that referenced this issue Oct 21, 2023
@Thenlie
#549 fix click on carousel storybook
a1ffcc6
@Thenlie
Copy link
Owner Author

Thenlie commented Oct 21, 2023

I was able to figure out a solution/workaround to properly handle this. Closed by #628

@Thenlie Thenlie closed this as completed Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thenlie Thenlie

Labels
type: bug Something isn't working type: storybook Creating or updating a storybook file
Projects
None yet
Milestone
1.10.0
Development

Successfully merging a pull request may close this issue.

fix storybook clicks Thenlie/Streamability
1 participant
@Thenlie