chore(android): refactor audio focus #4176
Draft
+264
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move audio focus management in a dedicated kotlin file create RNVPlayerInterface to be able to handle generic code Add lazy init of audioFocusDelegate (will not be instanciated if not necessary)
freeboub
requested review from
YangJonghun,
seyedmostafahasani and
KrzysztofMoch
| * Delegate audio management to this class | ||
| * This is an helper to group all generic android code which do not depend on player implementation | ||
| */ | ||
| class AudioManagerDelegate(player: RNVPlayerInterface, themedReactContext: ThemedReactContext) { |
There was a problem hiding this comment.
We can add private val because they are not expected to change after initialization.
Suggested change
| class AudioManagerDelegate(player: RNVPlayerInterface, themedReactContext: ThemedReactContext) { | |
| class AudioManagerDelegate(private val player: RNVPlayerInterface, private val themedReactContext: ThemedReactContext | |
| )``` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WIP
refactor audio focus listener to kotlin
Motivation
Changes
Move audio focus management in a dedicated kotlin file
create RNVPlayerInterface to be able to handle generic code
Add lazy init of audioFocusDelegate (will not be instanciated if not necessary)
Test plan