-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(android): video player play/pause during incoming calling #3924
base: master
Are you sure you want to change the base?
chore(android): video player play/pause during incoming calling #3924
Conversation
External interruptions, including incoming calls, are typically controlled by listening for audio focus events. |
@YangJonghun thanks for sharing your knowledge with me. |
I agree with @YangJonghun it wouldbe better to handle the change only with audio focus management if possible. |
Sure, I agree with you. Let me change the code. |
@seyedmostafahasani |
@YangJonghun, The user can handle it with this prop, but as you said earlier, I want to implement it internally specifically for incoming calls. We have quite a few users who are trying to learn RN recently, so they can’t work with these props well. |
I have a major issue with the requested permission here! To be able to merge this PR, we need:
according to @YangJonghun I think this phone call handling shall be done only with the onAudioFocusChanged callback... And regarding to the expected behavior (pause / mute / stop playback) a new prop should be added to indicate the expected behavior. In a second step this |
Summary
Handle video player play/pause during incoming calling
Motivation
close this issue
Changes
Add a new listener to handle different situations.
Test plan
You can play the video during an incoming call the video will pause automatically, and after the call ends, the video will resume.