fix(android, exoplayer): ensure playback progress is reported #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! As soon as we get it reviewed it will be merged! |
This was referenced May 21, 2022
armands-malejevs
requested changes
Jun 13, 2022
| private final Handler progressHandler = new Handler() { | ||
| @Override | ||
| public void handleMessage(Message msg) { | ||
| switch (msg.what) { | ||
| case SHOW_PROGRESS: | ||
| if (player != null |
There was a problem hiding this comment.
Why did you remove this null check? Wouldn't it be safer to leave it there? (I'm OK with removing the state checks, but null check might be beneficial here).
There was a problem hiding this comment.
I fully agree ! change done
added 2 commits
June 15, 2022 21:57
…native-video into fix/report_time_position_when_updated # Conflicts: # CHANGELOG.md # android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java
armands-malejevs
approved these changes
Jun 15, 2022
added 3 commits
June 23, 2022 21:55
# Conflicts: # CHANGELOG.md
…native-video into fix/report_time_position_when_updated # Conflicts: # CHANGELOG.md
…eelSmart/react-native-video into fix/report_time_position_when_updated
|
Just fix conflict, ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(android, exoplayer): ensure playback progress is reported even if player is paused
Adresses #2141 on Android.
and shall fix: #2372
Provide an example of how to test the change
A live channel sample is available in basic sample.
On live stream, position indicator keeps updating after playback is paused.
Focus area
You can ensure that position is not reported too often
Describe the changes