Fix video height and width is undefined when playing HLS in ios #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| // As HLS items would not have video track, we need another way to get the video size | ||
| width = [NSNumber numberWithFloat:_playerItem.presentationSize.width]; | ||
| height = [NSNumber numberWithFloat:_playerItem.presentationSize.height]; |
There was a problem hiding this comment.
Maybe calculate orientation as well?
orientation = width > height ? @"landscape" : @"portrait";
|
Hi! Any ideas about when this is going to be merged? I really need this |
|
Closing this in favour of #1992 as I didn't hear back from contributor and changelog was missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide an example of how to test the change
Test with HLS, example: https://bitdash-a.akamaihd.net/content/sintel/hls/playlist.m3u8
Describe the changes
As the number of video asset in player item is zero when playing HLS, we need to get the video size by _playerItem.presentationSize
####Related Issues
#1194