Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] dont set reactViewController view frame to whole screen #1931

Merged
merged 2 commits into from
Feb 27, 2020
Merged

[fix] dont set reactViewController view frame to whole screen #1931

merged 2 commits into from
Feb 27, 2020

Commits on Feb 26, 2020

  1. [fix] dont set reactViewController view frame to whole screen 

    - only set the view frame when video is being presented as fullScreen

this fixes the case on any time you have a react view that displays the video, but its being rendered with controls but not as a full screen (ie. easily reproducible when you have a tabbar for instance - the reactViewController.view frame shouldnt be the whole screen bounds).
    @marlonandrade
    marlonandrade committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    0c32e23 View commit details
    Browse the repository at this point in the history

  2. [chore] update CHAGELOG.md

    @marlonandrade
    marlonandrade committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    3dfc8ed View commit details
    Browse the repository at this point in the history