Luke's Multiple Fixes #36
Conversation
|
End splash screen preview
|
Maybe have some other information here. I don't think there is anything that would actually be helpful to present here, but even like a total elapsed time or random shiny stats to make it feel more "complete" |
src/lib.rs
Outdated
| .unwrap_or_else(|| String::from(DEFAULT_OUTPUT_PATH)), | ||
| ); | ||
| } else { | ||
| panic!(); |
There was a problem hiding this comment.
nit: use unreachable!("App always in the running state on startup")?
There was a problem hiding this comment.
unreachable gets completely taken out in release builds, which I'm not sure if I'm comfortable with the program continuing in any case, even if we test it in debug mode. I'll change it to panic with a message though.
I sort of agree, I'll add some text saying "Trial data saved to: ...", but besides that, in theory it would take pretty much the same time every run, unless the person has a response time of 3 seconds because they were eating a sandwich at the same time, I don't think anything like that would be helpful. |
|
Slightly better end splash screen:
I don't know what else could be added without it just being completely useless |
Changes: