fix(nix): remove duplicate spirv-headers function arg (#81) - #117
Merged
Conversation
Two well-meaning fixes both added `spirv-headers` to the package.nix
function pattern arglist (line 19 and line 22 on current HEAD), causing
a hard parse-time failure on any nix evaluation:
error: duplicate formal function argument 'spirv-headers'
at .devops/nix/package.nix:22:3:
21| shaderc,
22| spirv-headers,
| ^
23| useBlas ?
Drops the second occurrence. The remaining single declaration is what
the rest of the file actually references (line 19 binds the input;
`vulkanBuildInputs` and `nativeBuildInputs` consume it once each).
Reported by @cguentherTUChemnitz in #81 (originally), then re-confirmed
by @alanscodelog on the current tip after two prior fix attempts both
landed the same line.
Verified: fixed file parses clean via nix-instantiate; injecting the
duplicate back reproduces the exact error message above.
Closes #81.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
crusaderky
pushed a commit
to crusaderky/llama.cpp
that referenced
this pull request
Aug 9, 2026
) The v0.4.0 router hardening (bdee25a) dropped status.args and status.preset from get_router_models, diverging from upstream and breaking clients like pi-llama-cpp that parse launch args (e.g. --ctx-size) of unloaded models. Restore upstream parity; sanitization stays stronger than upstream via remove_sensitive_options() in unset_reserved_args() and is_sensitive skips in to_args()/to_ini(). Update docs that claimed argv/presets are never returned, and add a router unit test asserting both fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #81 — re-reported on current HEAD by @alanscodelog (comment).
.devops/nix/package.nixhadspirv-headersdeclared twice in the function pattern arglist (line 19 and line 22), causing every nix evaluation to fail at parse time:Two prior fix attempts both added the same line — this PR drops the duplicate.
Verification
Tested with
nixos/nix:latestDocker container:nix-instantiate --parseerrors with the exact message above (verified by injecting the duplicate back into a copy of the fixed file).nix-instantiate --parse .devops/nix/package.nixexits 0 and emits the parsed AST. Singlespirv-headersdeclaration remains, consumed byvulkanBuildInputsandnativeBuildInputs.Closes