Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NS uplink testing #870

Merged
merged 5 commits into from
Jul 2, 2019
Merged

NS uplink testing #870

merged 5 commits into from
Jul 2, 2019

Conversation

rvolosatovs
Copy link
Contributor

@rvolosatovs rvolosatovs commented Jun 27, 2019 •
edited
Loading

Summary

References #42 (closes NS part)

Changes

  • Add testing utilities for events
  • Reimplement NS uplink testing
  • Harmonize NS testing
  • Do not deduplicate uplinks, which NS cannot process

Notes for Reviewers

Requires #860

@rvolosatovs rvolosatovs added blocked This can't continue until another issue or pull request is done blocking Another issue or pull request is waiting for this labels Jun 27, 2019
@rvolosatovs rvolosatovs added this to the June 2019 milestone Jun 27, 2019
@rvolosatovs rvolosatovs requested a review from htdvisser as a code owner June 27, 2019 17:11
@rvolosatovs rvolosatovs self-assigned this Jun 27, 2019
@rvolosatovs
Copy link
Contributor Author

Blocked by #858

@rvolosatovs rvolosatovs mentioned this pull request Jun 27, 2019
Merged
@rvolosatovs rvolosatovs added the c/network server This is related to the Network Server label Jun 27, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 73.081% when pulling 1cb5c55624d314aac77db38566e037f27365c0cc on rvolosatovs:feature/ns-testing into 14be53a on TheThingsNetwork:master.

@rvolosatovs rvolosatovs reopened this Jun 28, 2019
@rvolosatovs rvolosatovs changed the base branch from master to feature/ns-uplink June 28, 2019 09:10
@rvolosatovs rvolosatovs removed the blocked This can't continue until another issue or pull request is done label Jun 28, 2019
@johanstokking johanstokking modified the milestones: June 2019, July 2019 Jul 1, 2019
@htdvisser htdvisser removed their request for review July 2, 2019 08:19
@htdvisser
Copy link
Contributor

Removed my review assignment. Github requested me as code owner, but appartenly those "owned" files have since been removed from the Pull Request.

@rvolosatovs rvolosatovs merged this pull request into TheThingsNetwork:feature/ns-uplink Jul 2, 2019
@rvolosatovs rvolosatovs deleted the feature/ns-testing branch July 2, 2019 15:30
@rvolosatovs rvolosatovs mentioned this pull request Jul 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanstokking johanstokking johanstokking approved these changes

Assignees

@rvolosatovs rvolosatovs

Labels
blocking Another issue or pull request is waiting for this c/network server This is related to the Network Server
Projects
None yet
Milestone
July 2019
Development

Successfully merging this pull request may close these issues.
4 participants
@rvolosatovs @coveralls @htdvisser @johanstokking