Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Go protobuf API v2 #6032

Merged
merged 30 commits into from
Jan 25, 2023
Merged

Move to Go protobuf API v2 #6032

merged 30 commits into from
Jan 25, 2023

Conversation

adriansmares
Copy link
Contributor

Summary

Closes #2798
References https://github.com/TheThingsIndustries/lorawan-stack/pull/3445

Changes

  • Use API v2 protobuf inside our code base. The enterprise PR contains the reviews and more comments at large.

Testing

Enterprise tested with unit tests, end to end tests and staging deployment.

Regressions

N/A.

Notes for Reviewers

This is just CI. No need to review.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added the technical debt Not necessarily broken, but could be done better/cleaner label Jan 25, 2023
@adriansmares adriansmares added this to the v3.25.0 milestone Jan 25, 2023
@adriansmares adriansmares self-assigned this Jan 25, 2023
@github-actions github-actions bot added c/application server This is related to the Application Server c/device converter c/gateway conf server This is related to the Gateway Configuration Server c/gateway server This is related to the Gateway Server c/identity server This is related to the Identity Server c/join server This is related to the Join Server c/network server This is related to the Network Server c/packet broker agent This is related to Packet Broker Agent compat/api This could affect API compatibility compat/config This could affect Configuration compatibility compat/db This could affect Database compatibility dependencies Pull requests that update a dependency file tooling Development tooling ui/cli This is related to ttn-lw-cli ui/web This is related to a web interface labels Jan 25, 2023
@adriansmares adriansmares changed the base branch from v3.24 to v3.25 January 25, 2023 11:00
@adriansmares adriansmares marked this pull request as ready for review January 25, 2023 11:00
@adriansmares adriansmares merged commit ce55365 into v3.25 Jan 25, 2023
@adriansmares adriansmares deleted the feature/2798-remove-gogoproto branch January 25, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/application server This is related to the Application Server c/device converter c/gateway conf server This is related to the Gateway Configuration Server c/gateway server This is related to the Gateway Server c/identity server This is related to the Identity Server c/join server This is related to the Join Server c/network server This is related to the Network Server c/packet broker agent This is related to Packet Broker Agent compat/api This could affect API compatibility compat/config This could affect Configuration compatibility compat/db This could affect Database compatibility dependencies Pull requests that update a dependency file technical debt Not necessarily broken, but could be done better/cleaner tooling Development tooling ui/cli This is related to ttn-lw-cli ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate away from gogo/protobuf
1 participant