Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce tools go module #2568

Merged
merged 2 commits into from
May 25, 2020
Merged

Introduce tools go module #2568

merged 2 commits into from
May 25, 2020

Conversation

rvolosatovs
Copy link
Contributor

Summary

Closes #2493 #2495

Changes

  • Introduce tools go module

Notes for Reviewers

mage binary is now located at tools/bin/mage

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md. The target branch is set to master if the changes are fully compatible with existing API, database, configuration and CLI.
  • Testing: The changes are covered with unit tests. The changes are tested manually as well.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@rvolosatovs rvolosatovs added the tooling Development tooling label May 19, 2020
@rvolosatovs rvolosatovs added this to the May 2020 milestone May 19, 2020
@rvolosatovs rvolosatovs requested a review from johanstokking May 19, 2020 09:30
@rvolosatovs rvolosatovs self-assigned this May 19, 2020
@rvolosatovs rvolosatovs force-pushed the feature/tools-module branch 2 times, most recently from 5fe4502 to f9893b6 Compare May 19, 2020 09:37
@coveralls
Copy link

coveralls commented May 19, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 73.123% when pulling 668b1fbde2841aac151f6e08a547c599d58933ef on rvolosatovs:feature/tools-module into 5ee4942 on TheThingsNetwork:master.

@johanstokking johanstokking requested a review from htdvisser May 19, 2020 09:55
@rvolosatovs rvolosatovs force-pushed the feature/tools-module branch from f9893b6 to 668b1fb Compare May 19, 2020 10:06
htdvisser
htdvisser reviewed May 19, 2020
View reviewed changes
Copy link
Contributor

@htdvisser htdvisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! 👍

@rvolosatovs rvolosatovs force-pushed the feature/tools-module branch from 668b1fb to ea03839 Compare May 19, 2020 18:40
@rvolosatovs rvolosatovs mentioned this pull request May 19, 2020
Merged
6 tasks
@rvolosatovs rvolosatovs changed the base branch from master to develop May 19, 2020 18:41
@rvolosatovs
Copy link
Contributor Author

Changed base to develop to merge after #2573 is merged(which goes to develop) in order to avoid unnecessary merge conflicts and hopefully resolve some of the dependency hell

@rvolosatovs rvolosatovs added the blocked This can't continue until another issue or pull request is done label May 19, 2020
@rvolosatovs rvolosatovs force-pushed the feature/tools-module branch 4 times, most recently from 957ba89 to 1df964d Compare May 19, 2020 19:16
@johanstokking
Copy link
Member

Yep, good stuff, thanks!

@rvolosatovs rvolosatovs force-pushed the feature/tools-module branch from 1df964d to 51121e6 Compare May 20, 2020 16:41
@rvolosatovs rvolosatovs removed the blocked This can't continue until another issue or pull request is done label May 20, 2020
@rvolosatovs rvolosatovs marked this pull request as ready for review May 20, 2020 16:42
@rvolosatovs rvolosatovs force-pushed the feature/tools-module branch from 51121e6 to 7043024 Compare May 20, 2020 17:12
@rvolosatovs rvolosatovs force-pushed the feature/tools-module branch from 7043024 to bd1372d Compare May 20, 2020 17:26
@rvolosatovs
Copy link
Contributor Author

Replaced mage by our fork until magefile/mage#307 is merged.
It does not complicate lorawan-stack module dependency management, since this replacement is encapsulated in tools module.

@rvolosatovs rvolosatovs added dependencies Pull requests that update a dependency file documentation This involves writing user documentation labels May 20, 2020
@rvolosatovs rvolosatovs merged commit 2f72186 into TheThingsNetwork:develop May 25, 2020
@rvolosatovs rvolosatovs deleted the feature/tools-module branch May 25, 2020 13:29
This was referenced May 25, 2020
Merged
Merged
@htdvisser htdvisser mentioned this pull request Jun 3, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htdvisser htdvisser htdvisser left review comments

@johanstokking johanstokking johanstokking approved these changes

Assignees

@rvolosatovs rvolosatovs

Labels
dependencies Pull requests that update a dependency file documentation This involves writing user documentation tooling Development tooling
Projects
None yet
Milestone
May 2020
Development

Successfully merging this pull request may close these issues.
4 participants
@rvolosatovs @coveralls @johanstokking @htdvisser