Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protoc and related dependencies #2417

Merged

Conversation

rvolosatovs
Copy link
Contributor

Summary

Regular dependency update

Changes

  • Update protoc and related dependencies

Notes for Reviewers

Seems like some validation rules were missed before, which are now generated. Also some Swagger changes.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md. The target branch is set to master if the changes are fully compatible with existing API, database, configuration and CLI.
  • Testing: The changes are covered with unit tests. The changes are tested manually as well.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@rvolosatovs rvolosatovs added the dependencies Pull requests that update a dependency file label Apr 24, 2020
@rvolosatovs rvolosatovs added this to the April 2020 milestone Apr 24, 2020
@rvolosatovs rvolosatovs requested a review from htdvisser April 24, 2020 14:07
@rvolosatovs rvolosatovs self-assigned this Apr 24, 2020
@rvolosatovs rvolosatovs force-pushed the feature/update-protoc branch from 92c0705 to ed4d2c6 Compare April 24, 2020 14:07
@rvolosatovs rvolosatovs removed the request for review from adriansmares April 24, 2020 14:08
Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvolosatovs rvolosatovs removed the request for review from htdvisser April 24, 2020 14:09
@rvolosatovs rvolosatovs requested a review from htdvisser as a code owner April 24, 2020 14:20
@rvolosatovs rvolosatovs force-pushed the feature/update-protoc branch from 4d1274c to 37ecf0e Compare April 24, 2020 16:11
@rvolosatovs
Copy link
Contributor Author

rvolosatovs commented Apr 24, 2020

@htdvisser I attempted to update protobuf to 1.4.0, but that caused pkg/errors/web test failure, which I was not sure how to fix(and not sure whether it represents a regression somewhere), hence reverting the change and letting you handle this in next dependency update PR:

--- FAIL: TestErrorHandling (0.00s)

    --- FAIL: TestErrorHandling/Echo404 (0.00s)

        doc.go:66: 

            /home/travis/gopath/src/go.thethings.network/lorawan-stack/pkg/errors/web/middleware_test.go:46

            Expected '{"code":5,"message":"error:pkg/errors/web:unknown (Not Found)","details":[{"type_url":"type.googleapis.com/ttn.lorawan.v3.ErrorDetails","value":"Cg5wa2cvZXJyb3JzL3dlYhoJTm90IEZvdW5kIhgKFgoHbWVzc2FnZRILGglOb3QgRm91bmQ4BQ=="}]}

            ' to contain substring '"namespace":"pkg/errors/web"' (but it didn't)!

FAIL

coverage: 66.7% of statements

FAIL	go.thethings.network/lorawan-stack/pkg/errors/web	0.030s

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 73.003% when pulling 37ecf0e on rvolosatovs:feature/update-protoc into ad0fd12 on TheThingsNetwork:master.

@rvolosatovs rvolosatovs merged commit 60188e1 into TheThingsNetwork:master Apr 24, 2020
@rvolosatovs rvolosatovs deleted the feature/update-protoc branch April 24, 2020 16:50
@rvolosatovs rvolosatovs mentioned this pull request May 7, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants